locaal-ai/obs-urlsource

Styling problems due to invalid HTML?

Jeetah opened this issue · 8 comments

Jeetah commented

I think these are no proper HTML tag pairs (div not closed, no beginning text):

<body>
   <div id="text">{text}</text>
 </body>

Had some styling problems - could not find many supported stylings (e.g. text-shadow seems to have no effect). Perhaps that's the reason.

royshil commented

@Jeetah i can't see your HTML tags since markdown has parsed them
can you please write it again with backticks? e.g. `code` this will parse to code

  • 👍1
Jeetah commented

Provided.

royshil commented

yes your template should be

<div id="text">{{input}}</div>

you dont need body

royshil commented

@Jeetah any problems still? or can we close this issue

royshil commented

closing due to inactivity

Jeetah commented

I think we had a slight misunderstanding here - the above except was from YOUR code here and should probably be fixed:
https://github.com/occ-ai/obs-urlsource/blob/master/src/ui/text-render-helper.cpp

Perhaps this solves the problem that most styling have no effect?

royshil commented

@Jeetah yes you're right! i fixed it and will have a release soon. thanks for poitning it out

  • 👍1
royshil commented

@Jeetah can you try #65 artifacts https://github.com/occ-ai/obs-urlsource/pull/65/checks to see if it resolved the problem? thanks!