Drupal 11 support
Opened this issue · 1 comments
andybroomfield commented
Fixes here for Drupal 11 support
- Replace jcookie with alternative
- Fix entity so it no longer uses deprecated code
- Fix strict types
- Fix full screen alert banner js-cookie
millnut commented
Hi @andybroomfield here are some more errors that need fixing For Drupal 11 which was reported by running upgrade status module on Drupal 10.3
web/modules/contrib/localgov_alert_banner/localgov_alert_banner.module | 146 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/modules/group_alert_banner/group_alert_banner.module | 106 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/modules/group_alert_banner/group_alert_banner.module | 107 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Access/AlertBannerEntityPageAccess.php | 25 | Only booleans are allowed in &&, mixed given on the right side.
web/modules/contrib/localgov_alert_banner/src/AlertBannerEntityListBuilder.php | 20 | Implicit array creation is not allowed - variable $header does not exist.
web/modules/contrib/localgov_alert_banner/src/AlertBannerEntityListBuilder.php | 30 | Implicit array creation is not allowed - variable $row does not exist.
web/modules/contrib/localgov_alert_banner/src/AlertBannerEntityTypeListBuilder.php | 17 | Implicit array creation is not allowed - variable $header does not exist.
web/modules/contrib/localgov_alert_banner/src/AlertBannerEntityTypeListBuilder.php | 26 | Implicit array creation is not allowed - variable $row does not exist.
web/modules/contrib/localgov_alert_banner/src/Controller/AlertBannerEntityController.php | 93 | Implicit array creation is not allowed - variable $build does not exist.
web/modules/contrib/localgov_alert_banner/src/Controller/AlertBannerEntityController.php | 99 | Implicit array creation is not allowed - variable $build does not exist.
web/modules/contrib/localgov_alert_banner/src/Entity/AlertBannerEntity.php | 152 | Only booleans are allowed in an if condition, mixed given.
web/modules/contrib/localgov_alert_banner/src/Form/AlertBannerEntityRevisionRevertTranslationForm.php | 93 | Only booleans are allowed in \|\|, mixed given on the right side.
web/modules/contrib/localgov_alert_banner/src/Form/AlertBannerEntityStatusForm.php | 60 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Form/AlertBannerEntityStatusForm.php | 74 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Form/AlertBannerEntityStatusForm.php | 116 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Plugin/Block/AlertBannerBlock.php | 120 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Plugin/Block/AlertBannerBlock.php | 143 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Plugin/Block/AlertBannerBlock.php | 182 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Plugin/Block/AlertBannerBlock.php | 190 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Plugin/views/field/StatusPageLink.php | 69 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/src/Plugin/views/field/StatusPageLink.php | 72 | Construct empty() is not allowed. Use more strict comparison.
web/modules/contrib/localgov_alert_banner/templates/localgov-alert-banner-content-add-list.html.twig | 17 | Twig template modules/contrib/localgov_alert_banner/templates/localgov-alert-banner-content-add-list.html.twig contains a syntax error and cannot be parsed.
web/modules/contrib/localgov_alert_banner/localgov_alert_banner.libraries.yml | 0 | The 'alert_banner' library is depending on a deprecated library. The core/js-cookie asset library is deprecated in Drupal 10.1.0 and will be removed in Drupal 11.0.0. There is no replacement. See https://www.drupal.org/node/3322720
web/modules/contrib/localgov_alert_banner/modules/localgov_alert_banner_full_page/localgov_alert_banner_full_page.module | 34 | The 'localgov_alert_banner_full_page/full_page_alert_banner' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.
web/modules/contrib/localgov_alert_banner/modules/group_alert_banner/config/optional/views.view.group_alert_banners.yml | 627 | Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See https://www.drupal.org/node/3382316.
web/modules/contrib/localgov_alert_banner/localgov_alert_banner.info.yml | 4 | Value of core_version_requirement: ^9.4 \|\| ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.
web/modules/contrib/localgov_alert_banner/modules/localgov_alert_banner_full_page/localgov_alert_banner_full_page.info.yml | 4 | Value of core_version_requirement: ^8.8 \|\| ^9 \|\| ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.
web/modules/contrib/localgov_alert_banner/modules/group_alert_banner/group_alert_banner.info.yml | 5 | Value of core_version_requirement: ^8.8 \|\| ^9 \|\| ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.
web/modules/contrib/localgov_alert_banner/composer.json | 1 | The drupal/core requirement is not compatible with the next major version of Drupal. Either remove it or update it to be compatible. See https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file#core-compatibility.
web/modules/contrib/localgov_alert_banner/src/Controller/AlertBannerEntityController.php 142 Call to deprecated method renderPlain() of class [Drupal\Core\Render\Renderer](https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Render!Renderer.php/class/Renderer/10.3.0-rc1.x). Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use [Drupal\Core\Render\Renderer](https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Render!Renderer.php/class/Renderer/10.3.0-rc1.x)Interface::renderInIsolation() instead.