localgovdrupal/localgov_page

Use the "secondary banner" paragraph type instead of a new banner field

Closed this issue · 5 comments

We're currently using a new media field for the banner on localgov_page
We could/should use the secondary banner paragraph we already have in subsites (soon to move to localgov_paragraphs)

@markconroy remind me why this is a good idea (for the record)

We're going to need to faff about more with the labels , otherwise we have this which isn't ideal as we're not using the banner primary

Image

It means we can add a field for "Image style", but also means site can add more/other fields if they wanted to it. At the moment with just an image field, there's very little you can do, especially if (God forbid) someone wanted a slider that has image + text + XYZ.

It also means any updates we deploy to the banner paragraph type in the future will automatically be available to this field.

P.S. I don't think we should use just the banner secondary, let's use both - like we do with subsites.

P.S. I don't think we should use just the banner secondary, let's use both - like we do with subsites.

!

Lets put that the backlog. I can see the rationale, but might sense check what's there first.