replace calls to werkzeug.urls with urllib.parse
wobeng opened this issue · 6 comments
Hello
I noticed in line 17:
from werkzeug.urls import url_encode, url_unquote, url_unquote_plus
url_encode, url_unquote, url_unquote_plus is still being imported from werkzeug.urls instead of urllib.parse
Also, werkzeug just released 3.0.0 which has removed url_encode (and probably the others) which is breaking serverless-wsgi. Per the deprecation warning. https://github.com/pallets/werkzeug/blob/2.3.7/src/werkzeug/urls.py#L1235
have a hotfix + remove deps ready, but cant create pul request..
Happy to accept a PR. @dolfno let me know if I need to do anything, PR's normally work fine on this repo.
am i doing something wrong?
@dolfno You'll need to create your own fork first. Follow this guide: https://docs.github.com/en/get-started/quickstart/fork-a-repo#forking-a-repository
Then follow this one for submitting a PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
@logandk I created a PR as I had to fix it earlier anyway on my end, hopefully makes it easy enough. Thanks again for the cool script!