rsapi is not open-source

Question

rsapi is not open-source

george-hopkins opened this issue 2 years ago · 17 comments

Search first

I searched and no similar issues were found

What Happened?

Logseq contains a Node.js library @logseq/rsapi which is not open source. Amongst other things, this component seems to be essential to the encryption scheme (rsapi/ageEncryptWithPassphrase). This hinders the inspection of these methods considerably. In addition, the project no longer adheres to the AGPL.

Reproduce the Bug

@logseq/rsapi can not be built from scratch

Expected Behavior

rsapi is open-sourced and the project is fully AGPL-compatible

Screenshots

No response

Desktop or Mobile Platform Information

all platforms

Additional Context

#8870

Are you willing to submit a PR? If you know how to fix the bug.

I'm willing to submit a PR (Thank you!)

brokenpip3 commented 2 years ago

thanks!

👍1

Answer 1 · 2023-05-07T05:10:38.000Z

open-sourcing rsapi is on the plan.
cc. @andelf

Answer 2 · 2023-06-13T09:22:24.000Z

It has been a month, is it difficult to open source a module? Where are you stuck?

Answer 3 · 2023-06-13T09:25:41.000Z

@huangyinhaow Sorry. I will ping the team for the update on the progress

Answer 4 · 2023-06-13T09:27:38.000Z

@huangyinhaow Sorry. I will ping the team for the update on the progress

Thanks for your prompt reply! Hope you can close this issue soon!

Answer 5 · 2023-06-28T16:19:24.000Z

We are planing to open-source when the recent diff-merge feature is stabled.
#9238
#9748

As a software curated in the FOSS community, we always know the importance of local-first, privacy & E2EE. And we have many nice observers from the community.
Many doc stuff are not prepared as the Logseq Sync is still in beta and under rapid change, but in the formal launch it will be shipped with open-sourced client-side codebase and tech document coverage. We are also pushing our process on GDPR certificating.
There are too many stuff to do, and it could be a bit overwhelming for a small team. But Logseq Sync is strictly following E2EE and we are on the track to improve the transparency to users (especially non-techs)

Answer 6 · 2023-09-22T14:44:42.000Z

Just bumped into this when trying to run Logseq on FreeBSD:

Error: Cannot find module '@logseq/rsapi-freebsd-x64'

Waiting for opensourcing too.

Answer 7 · 2023-09-29T16:11:58.000Z

Any updates?

Answer 8 · 2023-10-27T11:28:16.000Z

Any movement on this?

Answer 9 · 2023-10-29T21:53:31.000Z

We are planing to open-source when the recent diff-merge feature is stabled.
#9238
#9748

It looks like these were both merged about 4 months ago. Is there any update on this?

I found this: https://www.npmjs.com/package/@logseq/rsapi?activeTab=code
Is it the code in question? It seems to have been open sourced as MIT 2 months ago.

Answer 10 · 2023-10-31T14:41:14.000Z

@fivestones It looks like it's still closed source. The package you mentioned is just a wrapper around platform-specific binaries (e.g. @logseq/rsapi-linux-x64-gnu)

Answer 11 · 2023-10-31T21:39:21.000Z

@george-hopkins Yeah you're right.
@cnrpman

Answer 12 · 2023-11-02T10:53:15.000Z

Thanks for your reminder.

It takes time to filter out old commits, which might contain secret keys or credentials for historical reasons.

So I just strip out old commits. Sorry for the inconvenience. Check it at https://github.com/logseq/rsapi

Regarding the Logseq Sync implementation, the underlying code is not confidential. You can find the Swift implementation of the iOS version on GitHub, which is open-source.

See-also: #10449

Answer 13 · 2023-11-02T17:22:08.000Z

Close as resolved.

Answer 14 · 2023-11-02T20:29:11.000Z

Thanks @andelf!

Answer 15 · 2023-11-04T21:57:57.000Z

Also just wanted to say thanks for taking the time to open-source this, it's much appreciated!

Answer 16 · 2023-11-06T09:06:35.000Z

Just as another gratitude for open sourcing this, it allowed me to create a port of Loqseq for FreeBSD. My port will land FreeBSD Ports tree in a couple of days.