logstash-plugins/logstash-codec-netflow

Unary vs Binary operator warning

Closed this issue · 2 comments

Thankfully, it appears that Ruby is doing the Right Thing™:

$LS_HOME/vendor/bundle/jruby/2.3.0/gems/logstash-codec-netflow-3.5.1/lib/logstash/codecs/netflow/util.rb:208: warning: `-' after local variable or literal is interpreted as binary operator
$LS_HOME/vendor/bundle/jruby/2.3.0/gems/logstash-codec-netflow-3.5.1/lib/logstash/codecs/netflow/util.rb:208: warning: even though it seems like unary operator

Line 208:

string  :padding, :read_length => lambda { flowset_length - 4 - scope_length - option_length - 2 - 2 -2}

To fix the warning, the proposed change is for the last -2 to be - 2

59f65f8

I accidentally committed this directly in Github's edit feature which defaults to commit instead of a PR. My bad.

Closing assuming my commit fixed it.