logstash-plugins/logstash-patterns-core

Should the SPACE grok pattern match zero or more?

zestysoft opened this issue · 2 comments

I noticed that the SPACE grok pattern is currently set to:

SPACE \s*

If it is meant to match whitespace, shouldn't it have a starting point where it matches at least one character? Something like:

SPACE \s+

I've ran into a situation where this pattern was skipped because it allows matching zero spaces.

kares commented

you're right but at this point changing the behavior would be a breaking change,
still LS allows using pattern overrides ... if anyone is unhappy with SPACE behavior

I don't use LS anymore