logzio/logzio-dotnet

Data format changed?

Closed this issue · 4 comments

spib commented

Hi,

We just upgraded the lo4net appender from version 0.20.0 to the latest 1.0.1, and we've noticed that the data is now being shipped in a 'logData'

Here's an example posted from v0.20

image

And then an example from v1.0.1

image

Was this an intentional change? Seems like a step backwards?

snakefoot commented

Think the change was made to allow support for any number of parameters:

See also:
https://logging.apache.org/log4net/release/sdk/html/P_log4net_Core_LoggingEvent_Properties.htm

One could argue that mandatory parameters like "timestamp" + "mesage" + "level" + "logger" could be included in the primary scope, instead of in the LogData-collection (of random properties). But maybe a developer at Logzio have a better explanation.

idohalevi commented

@spib
I feel like you are correct,message and timestamp should be in the primary scope, I will take a look to see what cause this change

snakefoot commented

@idohalevi Sorry about this. Believe it is my fault. I have now created #23 to fix this (Serialize only the LogData-Dictionary and not the entire LogEvent)

idohalevi commented

@snakefoot
Thank you!

@spib
I'll try to release a new version this week