logzio/logzio-helm

Allow windowsDaemonset resource to be created conditionally

Opened this issue · 2 comments

gsrai commented

Hello,

When rendering the logzio-fluentd helm template locally, the windows DaemonSet is also created.

Is there any way of preventing this? I tried setting the windowsDaemonSet value to null but that causes a null pointer exception (expected).

I am happy to raise a PR to wrap the windows DaemonSet in a conditional.

Thanks

How to replicate

run helm template logzio-fluentd --repo https://logzio.github.io/logzio-helm -f ./values.yml > "fluentd-logzio.yml"

values.yaml:

secrets:
  enabled: false

namespace: "helm-test"

nameOverride: "fluentd"
fullnameOverride: "fluentd"

serviceAccount:
  name: "fluentd"

daemonset:
  affinity: null
  logzioLogLevel: warn
  fluentdSystemdConf: null
  cri: null
  resources:
    limits:
      memory: 200Mi
    requests:
      cpu: 100m
      memory: 200Mi

configMapIncludes: <includes hidden>

configmap: <overrides hidden>

Hi @gsrai ,
Thank you for reaching out and pointing out this issue.
If possible, a PR with a fix would be great.

@mirii1994 would you be able to take a look at PR #413? Thanks