add a prop for <li> and <a> class

Question

add a prop for <li> and <a> class

marsPure opened this issue 8 years ago · 3 comments

Thank you for creating this project, I want to add bootstrap 4 pagination classes to the component and I have to pass class names to <li> and <a> too, can you please add optional props for those tags?

PS: or I can submit a pr if you think it is a good idea.

Answer 1 · 2017-02-09T04:25:31.000Z

Hi @marsPure , many thanks for the review. I will make some changes add add i PR soon then we can review it together.

Answer 2 · 2017-02-09T14:04:14.000Z

Hello @marsPure . You can check the changes in the PR. Also you can run the demo by clone the project and run npm install then npm run demo. I have published a new version v0.3.0 with the latest changes. Thanks.

Answer 3 · 2017-02-09T16:04:13.000Z

it works great, thank you so much. one more small issue for me was Bootstrap 4 overwrite the link color if the href doesn't exist so it won't be blue. I am not sure if you want to add this to your whole package or not, so I forked it. thank you so much for responding so quickly.