longbill/jquery-date-range-picker

remove bind and unbind method

Closed this issue · 3 comments

yonisolo commented

As of JQuery 3.0, bind and unbind will be deprecated (CF JQuery migrate), it requires to level up the minimum stability to JQuery 1.7, but i think that JQuery 1.3 is quite old.
I did tests with on(bind) and off(unbind) instead (just replaced) and it seems to work well. However, I didn't test all the cases... If you could check this, it would be great!!
Thx

holtkamp commented

Thanks for the pointer. It would be nice if you opened a Pull Request for this, so we can review it and work on this as a community...

I think there is no problem in raising the minimum required JQuery version to 1.7, as explained here this would not require bumping the major version... Bumping the minor version would suffice.

  • 👍1
yonisolo commented

Thank you for your answer :)