lookinlab/adonis-lucid-soft-deletes

Wrong interfaces for ignoreDeleted and ignoreDeletedPaginate methods

Closed this issue · 1 comments

These interfaces describe both methods as if they had no parameters:

type ModelWithSoftDeletes = LucidModel & {
ignoreDeleted(): void
ignoreDeletedPaginate(): void

export interface SoftDeletesMixin {
<T extends NormalizeConstructor<LucidModel>>(superclass: T): T & {
ignoreDeleted(): void,
ignoreDeletedPaginate(): void

But they actually have one:

public static ignoreDeleted<Model extends typeof ModelWithSoftDeletes>(
query: ModelQueryBuilderContract<Model>
): void {

public static ignoreDeletedPaginate ([countQuery, query]): void {

Prerequisites

  • "@adonisjs/lucid": "18.0.0"
  • "adonis-lucid-soft-deletes": "1.4.3"

Fixed v1.4.4