Cache plugin name regex objects

Question

Cache plugin name regex objects

Ortham opened this issue 3 years ago · 2 comments

Compiling plugin regexes is responsible for 63% of the time spent calling MetadataList::FindPlugin, and 25% of the time spent constructing PluginItem objects in LOOT:

Answer 1 · 2022-01-01T22:35:28.000Z

With a global cache (static std::map<std::string, std::regex>) hacked in, things look a lot better:

Answer 2 · 2022-01-02T11:48:36.000Z

Done in 15781c9.