lora-aprs/LoRa_APRS_Tracker

batteryVoltage and batteryChargeCurrent are sent with every beacon

hb9fef opened this issue · 1 comments

if (BatteryIsConnected) { aprsmsg += " - _Bat.: " + batteryVoltage + "V - Cur.: " + batteryChargeCurrent + "mA"; } (line 239 of LoRa_APRS_Tracker.cpp) should be inside of if (!(rate_limit_message_text++ % 10)) just above that section.

In the current version the battery status is sent with every single beacon (9 times) while 'aprsmsg + Config.beacon.message + Battery status' will be sent only every 10th time.

As a consequence, the user configured message is not visible on aprs.fi 9 out of 10 times.

Again, that is an insane waste of LoRa Bytes, unnecessary limiting channel capacity and chances on successful packet reception!

Luckily, I do not see this with my T-Beam v0.7, which thinks it remains connected to USB power all the time, even when it is solely cell operated. T-beam v1.0 users have less luck.