loreanvictor/themed-jss

Idea: Maybe don't diff styles for dark mode?

Opened this issue · 0 comments

I really don't like the !darkmode override kind of brings in the knowledge that dark mode overrides come after the usual styles, basically failing in masking dark-mode related chore. We can, instead of using !darkmode, just include recalculate the styles in dark mode and include them whole sale in the related media queries and overrides, instead of just diffing the properties that do change.

Pros

  • Simpler logic (which means faster application bootstrapping)
  • Same rule priorities (no need for !darkmode)

Cons

  • Tons more CSS
  • Am I missing something? Perhaps further testing shows more cons and complexities.