Handling invalid proofs
Opened this issue · 2 comments
lorenzb commented
On receiving an invalid proof, theProvethVerifier contract currently:
- either reverts
- or doesn't revert and notifies the caller that the proof wasn't valid.
It should be either one or the other.
relyt29 commented
Well, according to the solidity documentation,
"Catching exceptions is not yet possible."
so maybe that influences this decision, personally I think reverting is saner, but if the EVM doesn't support catching exceptions then that leaves a developer with no real way of doing anything other than bubbling up and reverting as well, if a MPP fails
lorenzb commented
Agreed, let's revert.
We could handle exceptions with a low-level solidity "exception handler" that catches reverts and returns invalid instead.