lostisland/faraday-retry

What code raises RetriableResponse?

jcoyne opened this issue · 2 comments

jcoyne commented

I see that it is handled by this middleware, but what code raises it?

olleolleolle commented

No library code, but perhaps your application code could raise that error, when you wanted to?

https://github.com/search?q=org%3Alostisland+RetriableResponse&type=code

jcoyne commented

I wonder if this should be removed from the Retry::Middleware::DEFAULT_EXCEPTIONS. It's more straightforward to just pass the exceptions one wants to rescue to the middleware.

The approach of having a retriable exception made sense in Faraday 1.0, when it was actually used by exceptions that were retriable, but now it seems unnecessary.

  • 👍1