ltguillaume/music-folder-player

some ideas to improve the app

jranma opened this issue · 10 comments

jranma commented

this script is exactly what I was looking for: very simple (almost no install), no database, supports folders... thanks for the good work !

Here are some ideas to improve it:

  1. a "logout" link, to logout from HTTP auth
  2. A longer music progress bar. On mobile, it's very short, no precision at all with big fingers !
  3. support for image according to the song played
  4. multiusers support: each user has access to his own music, playlists etc, and can share them to other user
  5. share on: facebook, twitter buttons
  6. I would suppress the 4 icons on the left, which I fond confusing and have no real value (was trying to click on the settings button)
  7. ampache API support, so we can use apps to play music !
ltguillaume commented
  1. Logout button should work like this. There is no official way to do this, I found https://stackoverflow.com/questions/233507/how-to-log-out-user-from-web-site-using-basic-authentication to conjure up something, though. Chrome on Android may not play nice (does it ever?), let me know.
  2. Yeah I think this already is somewhat better in the 3.0 branch, but I'll check it out.
  3. I'll look into it #23 (done in 62e04f8)
  4. No, that's beyond the scope of MFP. It's not impossible, of course, because it's really easy to just run multiple copies of MFP in different folders. Sharing is covered.
  5. All that social media share stuff... not specific for each platform, definitely not gonna add that. Copy & paste is there already. What I might look into is a "generic share" button, so that (at least on Android), you can share it to any app that supports it).
  6. That's an esthetic thing, I like it the way it is.
  7. That is most definitely beyond the scope of MFP. Nevertheless, if you or someone you know could make that work, have at it! 😊
  • 👍1
jranma commented

Regarding fb and twitter sharing buttons, they work the same way as your WhatsApp link..they are plateform independant.
Salutations a la prochaine

ltguillaume commented

Regarding fb and twitter sharing buttons, they work the same way as your WhatsApp link..they are plateform independant.
Salutations a la prochaine

So it's with a single URL, too, not with authentication & tokens, JSON shite and whatever?

Chuck217 commented

I am loving MusicFolderPlayer -- Although I really have no use for the Sharing option -- Is there as easy way to disable it all together?

ltguillaume commented

In music.htm you could replace

		<div id="shares">

with

		<div id="shares" style="display:none>

and in music.js remove

		case 83:	// s
			if (url.length > 1) return;
			dom.share.click();
			setFocus(dom.share);
			break;
luiginobucosse commented

Hi, thank you for your beautiful app.
It would beautiful the option to change the sort order of the files: last modified, size, etc.

ltguillaume commented

This repo still has a lot of catching up to do compared to the v3.x branch that I've been running for almost a year now.

The thing is, I'm not too interested in doing so until I find a way to get it working properly on mobile devices (see #19).

That being said, I think that for most people it wouldn't be hard to implement what you request here, so maybe someone can put this in a fork.

ltguillaume commented

@Chuck217 I just made the "Share" part in the interface optional in the v3 branch: you can set sharing = false in the new configuration file music.ini. It will hide the Share button etc. and disable the keyboard shortcut.

Updating will be easier now the configuration is separate (see intructions).

Edit: v3 branch is now merged with master.

ltguillaume commented
  1. share on: facebook, twitter buttons

@jranma Share dialog with several services that have a web share URL and native share (via Web Share API, supported on Android, iOS and partially on desktops) is coming up! The latter, of course, is most important, because it basically allows you to share to any app.

image

ltguillaume commented
  1. share on: facebook, twitter buttons

@jranma Share dialog with several services that have a web share URL and native share (via Web Share API, supported on Android, iOS and partially on desktops) is coming up! The latter, of course, is most important, because it basically allows you to share to any app.

image

Ouch, that took a while. Had been using this for so long already, but I never committed it to this repo... until last month. 🙈

  • 👍1