ltog/osmi-addresses

Support roads with ref=*

Closed this issue · 7 comments

Regarding:

std::vector<std::string> keys = {"name", "name:left", "name:right", "alt_name", "official_name", "name_1"};

I went looking for how you match addr:street to highways and was pleased that you use variations on the name tag like official_name. Consider also including the ref tag which is "common for roads" (like "US 1") and when a name would only be duplicating the information in the ref=* tag, then the ref and noname=yes is appropriate.

Also consider removing name_1 since it is deprecated. And adding short_name.

Would you consider a pull request on this if I made one?

ltog commented

@blackboxlogic : Do you have a source for name_1 being deprecated?

@Nakaner , @woodpeck : What do you think?

https://wiki.openstreetmap.org/wiki/Names#Deprecated_tags says that number suffixes are deprecated. I think that it would make sense to drop name_1.

name_1 comes from iD users using the raw tag editor in iD (not the presets). If a user added name=something and then adds name=anything else in a row below, the second name is changed to name_1 automatically because keys are unique per OSM object. I think we should join the other editors (namely JOSM) which tell their users that they cannot use a key twice.

Is there anything I can do to help this forward?

I'm still hoping for your consideration on #119
-Alex