luc-github/ESP32SSDP

Fix Compilation failure on esp32 Core Version 3.0.0

Closed this issue · 10 comments

Daedelos commented

Describe the bug
Changes in rel 3.0.0 of esp32 result in compilation failures

. . . \libraries\ESP32SSDP-1.2.1\src\ESP32SSDP.cpp:158:5: error: 'tcpip_adapter_ip_info_t' was not declared in this scope; did you mean 'tcpip_adapter_if_t'?
158 | tcpip_adapter_ip_info_t ip;
| ^~~~~~~~~~~~~~~~~~~~~~~

. . . \libraries\ESP32SSDP-1.2.1\src\ESP32SSDP.cpp:160:13: error: 'tcpip_adapter_get_ip_info' was not declared in this scope; did you mean 'tcpip_adapter_if_t'?
160 | if (tcpip_adapter_get_ip_info(TCPIP_ADAPTER_IF_STA, &ip)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~

To Reproduce
Use esp32 rel 3.0.0

Expected behavior
Compilation without errors

Firmware:

  • ESP core version: 3.0.0
  • Library Version: 1.21
  • Wifi mode:STA

Board used (please complete the following information):

  • MCU: doit esp32
luc-github commented

Expected behavior
Compilation without errors

Sorry wrong expectation : https://esp3d.io/esp3d/v3.x/installation/arduino/index.html
Currently only esp32 2.0.8 is supported

esp32 3.0.0 release is a break changes and I am waiting platformio is also supporting fully the esp32 3.0.0 release to work more on it - I have started already https://github.com/luc-github/ESP3D/tree/arduino-esp32-3.0.0-devt and even reported some issues, but this is currently a work in progress because libraries dependencies (like the error you mention) need also to be updated , and because it is breaking change I need to be sure everything is up to date.

I need to clarify this on readme for SSDP

Daedelos commented

Thanks. I'll give it a go.

luc-github commented

Please, let me know your feedback on it, sample code is limited for stress tests.
Also, because it seems esp32 3.0 porting to platformio has some issue, and can be delayed, I will work on SSDP 2.0 next week with arduino only support, the code base will be the one I gave you, so I would appreciate your feed back on real usage than sample code

luc-github commented

@Daedelos I did this branch for the 2.0 : https://github.com/luc-github/ESP32SSDP/tree/v2.x
I have compiled the sample code with esp32 core v 3.0.0 and so far it is ok on my side

Daedelos commented

Looking good. I have incorporated the code into one of my larger projects and it is working well. I will do some further testing. Many thanks.

luc-github commented

cool - I am waiting your final feedback then to close the ticket and do the release of 2.0.0 - thank you for your help

Daedelos commented

I've been using it on various clients for over 12 hours with no problems.

luc-github commented

Cool, I will do a release for version 2.0 tomorrow then.

I really appreciate the feedback - thank you.