lucassabreu/comment-coverage-clover

Exits with `0` exit code and without debug logging to indicate possible issue when no token is available in env

ermik opened this issue · 4 comments

ermik commented

The token usage or required scopes are undocumented

const token = getInput("github-token") || process.env.GITHUB_TOKEN;

and the returns are not logging anything

if (!github) return;
if (!context.payload.pull_request) return;

hi, i will try to find the required scopes, but the ideia was to use the one created by gh actions by default.

about the zero-exits, i will add some logs for that, and maybe a non-zero exit.

hi @ermik i added to the readme the scope, it needs repo. but is not required, the default token created by github should sufice.

Captura de tela de 2023-10-19 10-54-07

ermik commented

Hey @lucassabreu - appreciate the response. I'm gonna think of what else this can be expanded into. I'm definitely hitting an edge case where nothing is posted even though there's a clover file and a valid token... I think more debug output would be a general point of improvement.

if any error happens it will be shown in the logs, github actions ensures that.

could you post the workflow and workflow log @ermik ?