Use PBR for installation

Question

Use PBR for installation

Closed this issue 4 years ago · 6 comments

IMHO, setup.py files are ugly. Would there be interest in switching to PBR for installation? I'm more than happy to try and make it work myself, then submit a PR. ATM, it doesn't even seem possible to install the code from the next branch, and there's no requirements file or anything, so even for testing (especially for new developers), I reckon it would help.

Answer 1 · 2021-01-22T20:43:37.000Z

hi.
Before doing that, please check this: https://python-poetry.org/docs/pyproject/
And this: https://www.python.org/dev/peps/pep-0517/

Essentially, you can just do

pip install .

or

pip install path/to/lucia

and that is it.

Answer 2 · 2021-01-22T20:46:05.000Z

Ah, OK, didn't even realise those existed. I just saw the setup.py file and assumed from there. So why do you still have all that mess in setup.py? Obviously my PR is no longer applicable. Sorry, should have looked more into the systems you were using before diving in. Take care, Chris Norman

…

On Fri, 22 Jan 2021 at 20:43, Nicklas Tegner ***@***.***> wrote: hi. Before doing that, please check this: https://python-poetry.org/docs/pyproject/ And this: https://www.python.org/dev/peps/pep-0517/ Essentially, you can just do pip install . or pip install path/to/lucia and that is it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2P34FJACM5X3R7O6A3S3HPQPANCNFSM4WO5SRNQ> .

Answer 3 · 2021-01-22T20:54:46.000Z

If you clone the repository based on the next branch (wihtout first cloning the master), the only relating file in there is pyproject.toml and poetry.lock

If you still see a setup.py, that would be because you are either on the master branch, or have a branch based on the master branch

Answer 4 · 2021-01-22T21:00:17.000Z

Nope, I didn't see a setup.py file. I've never heard of this new-fangled system, so I just assumed you hadn't made a setup.py file because it wasn't ready for production. Thanks for the knowledge though, that's really helpful. Take care, Chris Norman

…

On Fri, 22 Jan 2021 at 20:55, Nicklas Tegner ***@***.***> wrote: If you clone the repository based on the next branch (wihtout first cloning the master), the only relating file in there is pyproject.toml and poetry.lock If you still see a setup.py, that would be because you are either on the master branch, or have a branch based on the master branch — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2JNVHDSNVRAPVC5653S3HQ2JANCNFSM4WO5SRNQ> .

Answer 5 · 2021-01-22T21:01:51.000Z

Fair enough.
I myself use poetry in all my python projects, and urge everyone else to do the same.

I'm going to close this issue, if something else comes up relating to this, feel free to reopen :)
Thanks for your contribution!

Answer 6 · 2021-01-22T21:05:17.000Z

Shall do. Thanks again. Take care, Chris Norman

…

On Fri, 22 Jan 2021 at 21:02, Nicklas Tegner ***@***.***> wrote: Fair enough. I myself use poetry in all my python projects, and urge everyone else to do the same. I'm going to close this issue, if something else comes up relating to this, feel free to reopen :) Thanks for your contribution! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2OOUZYJVSX733VCG2TS3HRU3ANCNFSM4WO5SRNQ> .