lucidrains/DALLE2-pytorch

How should i understand useing self conditioning in DiffusionPriorNetwork which is Hinton's group's new ddpm technique.

SELECT-FROM opened this issue · 3 comments

If self.self_cond is true , how should I understand learned_queries .

    if self.self_cond:
        learned_queries = torch.cat((image_embed, self_cond), dim=-2)

@SELECT-FROM that doesn't look right 😞 i believe it should be correct now

the logic should have been to include the self conditioning token just before the learned queries

@lucidrains Thank you for your reply.
I have another question is in what scenario or requirement should self conditioning be set to true? The default value false is always used in the init method of DiffusionPriorNetwork

@SELECT-FROM the whole field is very empirical

i would recommend just running a comparison test with that one flag self_cond toggled and go by the results you see