lucidrains/egnn-pytorch

Edge features thrown out

josejimenezluna opened this issue · 2 comments

Hi, thanks for this implementation!

I was wondering if the pytorch-geometric implementation of this architecture is throwing the edge features out by mistake, as seen here

if edge_attr is None:
edge_attr = torch.cat([edge_attr, rel_dist], dim=-1)
else:
edge_attr = rel_dist

Or maybe my understanding is wrong?
Cheers,

Closing this 👍