lucidrains/magvit2-pytorch

Maybe a small bug at magvit2_pytorch.py#L1236?

Closed this issue · 1 comments

AIWanderer-X commented

magvit2-pytorch/magvit2_pytorch/magvit2_pytorch.py

Line 1236 in e085ec3

Residual(TokenShift(FeedForward(dim, dim_cond = dim_cond)))

I noticed dim_cond is added into FeedForward with the block under elif layer_type == 'attend_time':. Shouldn't it be added into the block under elif layer_type == 'cond_attend_space': where dim_cond is currently missing in FeeForward?

lucidrains commented

@AIWanderer-X indeed! thank you again!