Names `to_k`, `to_q`, `to_v`, `to_out` cause issues
JamesDeAntonis opened this issue · 0 comments
JamesDeAntonis commented
Hi Lucid,
Hope all is well. Is there any need to have the q, k, v, o be named to_k
, to_q
, to_v
, to_out
? This causes lots of incompatibility with huggingface, since they call them q
, k
, v
, o
. Any chance we could change this to the HF convention?
Thanks!