Last change to helm chart, ingress.yaml broke ingress.enabled: false
javajon opened this issue · 3 comments
In the last updated this logic
{{- if .Values.ingress.enabled -}}
was removed from ingress.yaml in helm chart templates. This causes this scenario to break.
https://katacoda.com/javajon/courses/kubernetes-chaos/kubeinvaders
As a workaround, I added
git checkout dfd2625ee1555205d1b562a18492e7e1ac4e3b94 --quiet
to the scenario instructions to revert to the version that was previously tested with the scenario. Where the ingress.enabled: false was still working.
Once the kubeinvaders chart is corrected you can use this scenario as a testing channel by just skipping the checkout instruction.
Hi @javajon!
Thank you for your issue! I added the if statement in case of ingress disabled. From values.yaml is enabled by default.
The new command for installing is:
helm install kubeinvaders --set-string target_namespace="namespace1\,namespace2" --namespace kubeinvaders ./helm-charts/kubeinvaders --set ingress.hostName=kubeinvaders.io
Please let me know if the scenario is ok. You can pull the last changes from master branch