luckyframework/lucky

memoize doesn't work when there's an external name

jwoertink opened this issue · 2 comments

jwoertink commented

This code throws an undefined variable "thing" error:

memoize def needed?(for thing : Whatever) : Bool
  thing.does_stuff?
end

needed?(for: thing)
robacarp commented

Yeah, I've run into this myself. I feel like I've tried to capture the internal/external stuff in macros before and it didn't work...but that may have been 452 crystal versions ago...

jwoertink commented

Turns out, if you use arg.name it'll default to the external name... You have to use arg.internal_name which will either use the internal, or the regular arg name...

class Test
  macro memoize(method_def)
    {% puts method_def.name %}
    {% for arg in method_def.args %}
        {% puts arg.internal_name %}
      {% end %}
  end
  
  memoize def call(x y : String) : String
    "done"
  end
  
  memoize def run : String
    ""
  end
  
  memoize def exec(x : String) : String
    ""
  end
end

That would need to be updated everywhere we use arg.name in this file.

lucky/src/lucky/memoizable.cr

Line 22 in 22fcb18

macro memoize(method_def)

  • 🎉1