lujakob/nestjs-realworld-example-app

The official tests

sebilasse opened this issue · 5 comments

sebilasse commented

Hey there,

thanks for the work.
I've just run this project vs the official RealWorld API Tests : I would suggest to use these for testing.

[ Currently they return one false negative ( I had corrected that in the testcode already) but there are 2 PRs for that, e.g. https://github.com/gothinkster/realworld/issues/309 ]

There are a few problems like with the relations.
It looks like this
bildschirmfoto 2018-12-11 um 13 28 59

I have corrected the bugs and it looks like this
bildschirmfoto 2018-12-11 um 13 40 27

I'd prefer to make a fork and change it there so that you can review the code before merging anything.

lujakob commented

Awesome, thanks!

sajidali commented

@lujakob is this already implemented or is it still pending a PR from @sebilasse ? Please update.

lujakob commented

@sajidali There is no PR to update this.

  • 👍2
sajidali commented

@sebilasse please submit PR with your bug fixes...

SeongBrave commented

@sebilasse please submit PR with your bug fixes... 🙃

  • 😄2
  • ❤️2