lukemonahan/splunk_modinput_prometheus

Ability to add new dimensions

lukemonahan opened this issue · 2 comments

lukemonahan commented

I am planning on add the capacity for setting up a new dynamic dimension via stanza configuration. By new dimension I mean the hability to setup for example datacenter dimension so you may split data in the dashboard by datacenter if that dimensions is to set (for me a dimension is a property like the job property coming by default from Prometheus)

Originally posted by @sky-philipalmeida in #4 (comment)

lukemonahan commented

I am wondering if this is best done by either:

  1. Adding this label at the Prometheus end; or
  2. Maybe the Splunk Data Stream Processor (when it leaves beta) https://www.splunk.com/en_us/form/splunk-data-stream-processor.html

Instead of modifying the input itself? Do you have many cases where you can't do this via 1?

sky-philipalmeida commented

Thanks @lukemonahan for the information.
After looking into the point number 1, Adding this label at the Prometheus end...
Hi have find out that using global external_labels I could achieve what I wanted in a easy way (https://prometheus.io/docs/prometheus/latest/configuration/configuration/#configuration).

I can't find any use case where point number 1 would not fullfill the extra dimension labels.
Thanks.