New release, 2.0.1, 2.1.0?
bungle opened this issue · 23 comments
Several things have been added to master. Could we get a new release of busted?
A new release with this line changed to https:// would be most welcome.
https://github.com/Olivine-Labs/busted/blob/75b2c8930ed22d99dc5f6e41547ec333feee6197/busted-scm-2.rockspec#L4
busted scm-2 depends on mediator_lua >= 1.1.1 (not installed)
Installing https://luarocks.org/mediator_lua-1.1.2-0.rockspec
mediator_lua 1.1.2-0 is now installed in /usr/local (license: MIT <http://opensource.org/licenses/MIT>)
Cloning into 'busted'...
fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
Error: Failed cloning git repository.
Error: Process completed with exit code 1.
Edit:
Apologies, I tried my suggestion above and it looks like that won't actually work from the luarocks side.
That means that right now I'm not quite sure how one would proceed.
Edit 2:
Found it, git+https.
@DorianGray @ajacksified The last release was almost 4 years ago. Seems like you have moved on and/or changed priorities.
Would it be possible to transfer the repositories for busted, luassert, and say, to the lunarmodules organization? This would allow us to set up a new team and keep the project going forward.
I second that suggestion! Busted and friends are staples in the Lua ecosystem and deserve good active maintenance. I'm willing to pitch in some here and there as I have for other projects hosted there (Luacheck, LDoc, Penlight, etc.).
@Tieske I've checked in with @DorianGray and we're happy to transfer the repositories. I'll need permissions to create repositories on lunarmodules, and then I'll make the transfer. Thanks for offering to maintain these!
@ajacksified I took the liberty of assuming Tieske's approach to imply he trusted you with this and just spun up a new team (Team Busted) for managing maintainers of Busted, Luassert, and Say. You should have a team invite floating around GitHub somewhere. That should give you enough permissions to transfer the repos and you should still have access to them when they come across. We'll double check on that latter point and make sure @DorianGray anybody else from the current access list has whatever access they need going forward after repos are transferred.
Done - I'll just need to figure out how to set up a redirect for the docs, as it was on GitHub Pages.
Also, let me know if there's anything I need to do to get you access for luarocks or anything else.
@ajacksified The publishing to LuaRocks could me handled either of two ways:
-
You or whoever has access to the current olivine-labs user could add an API key to that account and add it as a secret to these 3 repos.
-
We can ask Hishamh to copy the module into the lunarmodules user which has an API secret this whole org can use to publish already.
I don't feel too strongly either way, perhaps @Tieske or others do. Both ways cause some end user confusion about who is who and what is what but both work in the end. A little bit of history gets lost when copying to a different user on LuaRocks, for example the release dates of old versions. Also the old namespace is still there so people following direct links can end up in the wrong place even if the package they get from luarocks install ... is the new package.
Note we already have some projects that have kept their previous publishers (e.g. Penlight) and some that have switched to Lunarmodules (e.g. Luacheck) so there really isn't a precedent. Whatever you guys think is best for the project...
If we don’t want to bother @ajacksified or @DorianGray again, then I think transferring the luarocks user to Lunarmodules makes the most sense to me. The lost history is a temporary thing anyway… my 2cts
Cool. What's the best way to go about that - should I ping @hishamhm?
Thanks!
Actually I didn't tag it. The v2.O.0 tag already existed from 2019. The only thing I did was mark the tag as being a GH Release. The issue I saw was all the other tags, notably over a dozen RC tags, were all marked as being GH releases but the final 2.0.0 was not. That was causing the GH repo to show RC13 or something like that as the "latest" release.
Unfortunately the GH interface shows the release date as when I marked it not the date of the tag that was marked, but if you click through to the release you'll see which commit is tagged and that the tag is from June 28, 2019.
I would suggest we:
- cleanup a few things in the repo like links and such
[ ] get the GH Action configuration working (see #689)- get the project copied to the lunarmodules namespace on luarocks.org
- then cut a 2.1 release with the 50ish commits since the last tagging.
I got notifications that luassert and say have been moved to lunarmodules as well on Github. I assume I should move those too on luarocks.org?
done!
Thanks @hishamhm.
BTW I nixed getting this repo to work as a GH action from my list at least for this cycle. It's quite possible to do but it will take a lot more fiddling to setup in a way that is useful to many project than the easy way I used for Luacheck, so I don't think that should hold up a release.
I think #689 should cover most of point 1. Otherwise we have some fiddly bits like making sure the changelog is sane and reflects the 3 years of commits.
I've posted PRs updating links and CI release related stuff for say, luassert, and busted. All of these three projects have minor improvements in commits since the last release. My personal idea at this point would be to merge all of those, then work through them in that order doing minor-version release bumps for each and making sure the automatic publishing stuff works.
I have tagged @Tieske as a potential reviewer on all three, but honestly I'd move forward with that plan if anybody in @lunarmodules gave it a skim and review approval for each.
These would basically be safe-harbor release representing the current Git HEAD for each project prior to migration to this org plus our release tooling buts. We could then look into further triaging open issues & PRs.
reviewed the say and luassert ones, some minor comments there. I think those should be released first, such that we can bump the dependencies with the new Busted version as well.
Kudos to everyone involved in making this happen! \o/