Lune panics on asynchronous roblox library calls
Closed this issue · 2 comments
jeparlefrancais commented
When I attempt to serialize multiple places asynchronously, I hit these result expect calls:
https://github.com/filiptibell/lune/blob/main/src/roblox/instance/mod.rs#L221
https://github.com/filiptibell/lune/blob/main/src/roblox/instance/mod.rs#L127
The error happens when I run that function under multiple task.spawn
:
local place = testPlace:Clone()
local model = roblox.deserializeModel(fs.readFile(modelPath))[1]
model.Parent = place:GetService('ReplicatedStorage')
fs.writeFile(testPlacePath, roblox.serializePlace(place))
filiptibell commented
There were a few unhandled cases of deadlocking in the instance implementation (these calls are multithreaded behind the scenes when ran in several lua threads), I went through and fixed any remaining deadlocking cases now and this issue will be fixed in the next release
jeparlefrancais commented
Awesome! Thank you 👍