lune-org/lune

Lune's `CFrame` does not always follow the correct ordering convention

kennethloeffler opened this issue · 1 comments

glam uses a strictly column-major representation, while several Roblox CFrame APIs (like CFrame:GetComponents() and CFrame.new(x, y, z, r00, r01, r02, r10, r11, r12, r20, r21, r22)) use row-major order. Lune needs to transpose appropriately for these kinds of methods.

This is also an issue for the impl From<DomCFrame> for CFrame , as rbx-dom represents the rotation matrix in row-major order