lupomontero/psl

punycode is deprecated in Node v21

Closed this issue ยท 8 comments

Using punycode is deprecated in Node v21. See documentation https://nodejs.org/api/punycode.html. Maybe try replacing with NPM Package punycode

punycode is used here:

psl/index.js

Line 5 in 797ccb4

var Punycode = require('punycode');

Fix:

  1. npm i punycode
  2. change from require("punycode") to require("punycode/")

AnWeber/httpyac#577

There is already a pull request from 2022 fixing this issue.

#298

3ddec00
See this commit and it may suggest that new version be released soon.

This is already fixed. We are just waiting for a new release. Patience is a virtue.

@jm42

This is already fixed. We are just waiting for a new release. Patience is a virtue.

Can you clarify why you suggest just waiting? Are you a maintainer and you are planning a release?

It's 2 months ago since @lupomontero added a series of commits into the master branch including the fix 3ddec00 for this issue.

If you are not a maintainer, then perhaps @lupomontero could say if/when a new release is planned?

Thank you for maintaining this package! I understand that it is a lot of work. It would be appreciated with a release that includes thix fix.

when is the next release? it's been almost a year.

thanks!

(also if you want help, I can lend a hand! I manage a fair number of packages)
(I know this reads as spam / malicious, I'm sorry, I don't know how to make it sound nicer)
image

Hi there, many apologies for taking so long to address this... I have just released a new version that should include a fix for this issue: https://github.com/lupomontero/psl/releases/tag/v1.10.0