Initialization inconsistency for _recommendation between LuxDataFrame and LuxSeries
cgarciae opened this issue · 1 comments
Just noticed that LuxDataFrame initializes _recommendation as a dict while LuxSeries initializes is as a list as show here:
LuxDataFrame:
Line 64 in 91e8e98
LuxSeries:
Line 60 in 91e8e98
I wonder if this is intended or is having a silent impact over the code base? More over, should I replicate this behaviour or fix this in #435?
The initialization should be set as a dictionary for both series and frame. The recommendation property is meant to be a key-value dictionary where the keys are the names of the actions and the value is a list of recommendations. Even in the case of a series where there is only one action, we still follow the key value dictionary convention. For example, see:
