Unmasking of masked systemd units is no longer possible
morphis opened this issue · 2 comments
With the changes introduced in #730 it is no longer possible to unmask services at runtime and a reboot of the system is required, unless both systemctl unmask foo.service and systemctl unmask --runtime foo.service are executed.
We mask several services in the Anbox image build but our test scripts expect them to be unmasked and usable again with a systemctl unmask foo.service. With the change from the PR all our tests are currently failing. Extending the tests to do both systemctl unmask foo.service and systemctl unmask --runtime foo.service feels wrong to me.
I am not entirely sure what the intention of the PR is but the description doesn't seem to fit the implementation. It says Allow masking units created by the lxc system-generator. whereas the code copies all masked units regardless if they have been created by the lxc system-generator or not.
Yes this seems like an unintended consequence to me. Can this be reverted @monstermunchkin ?
I will change it to only handle services created by the lxd generator.