[Screenshot] When using "Capture an area of the screen" on a monitor not on topleft position (not 0,0 coordinates) you can't select area.

Happens on my desktop when using the bottom screen, replicated on VirtualBox with openbox, xfwm4 and kwin_x11, see video:

lximage-select.mp4

Expected Behavior

Should be able to select area in any screen.

Current Behavior

Can only select area from topleft screen

Possible Solution

area selection dialog (the one that contains the first screenshot which is then used to select the area) covers all screens and lets you select anywhere.
area selection dialog shows only current screen (same current behaviour but with correct screen).

Steps to Reproduce (for bugs)

have 2 or more monitors (or add Display on VirtualBox)
open lximage-qt and drag it to a monitor that's not on 0,0 coordinates
select option "Capture an area of the screen"
click OK

System Information

LXimage-qt version: lximage-qt 1.0.0-1
Distribution & Version: Archlinux
Qt Version: qt5-base 5.15.2+kde+r277-1
liblxqt Version: liblxqt 1.0.0-1

lximage-qt's screenshot code won't be developed and might be removed. See lximage-qt --help.

If you see the same problem in screengrab, please open an issue for it.

If you see the same problem in screengrab, please open an issue for it.

Didn't know about Screengrab, it works fine there.

lximage-qt's screenshot code won't be developed and might be removed. See lximage-qt --help.

So no PR for it will be accepted? I have a quickfix for it, change:

lximage-qt/src/screenshotselectarea.cpp

Line 38 in 12d299b

setWindowState(windowState() | Qt::WindowFullScreen);

to:

  setWindowFlags(Qt::FramelessWindowHint | Qt::WindowStaysOnTopHint | Qt::X11BypassWindowManagerHint);
  setGeometry(image.rect());

also, should data/lximage-qt-screenshot.desktop.in be removed if it's deprecated?

So no PR for it will be accepted? I have a quickfix for it, change:

Some LXQt members think that the code should be removed; some others (me included) think that it can be left as it is but with a warning (as in --help). The first group is right in saying that screengrab is LXQt's screenshot utility and we shouldn't have parallel functionalities. The second group (I think Alf agreed with me) say that we shouldn't annoy users by removing what they've got used to.

Since you've found a simple fix for the problem, I see no reason why it shouldn't be merged.

also, should data/lximage-qt-screenshot.desktop.in be removed if it's deprecated?

Good idea! We could keep the code (for now) and remove lximage-qt-screenshot.desktop instead.

Would you please make 2 PRs, one for the fix and the other for removing the desktop entry? Sorry for the confusion!

Would you please make 2 PRs, one for the fix and the other for removing the desktop entry? Sorry for the confusion!

Ok, done.

Thanks!