interactive args: unclear error message when supplying args simultaneously

[SimonRenblad]

Bug Report

One-Line Summary

Simultaneous calls to InteractiveArgsDB.supply with the same RID may lead to duplicate calls to futures[rid].set_result.

Issue Details

If two calls to InteractiveArgsDB.supply with the same RID run before the corresponding InteractiveArgsDB.get coroutine deletes the future with the associated RID, an InvalidStateError is thrown instead of a ValueError.

Steps to Reproduce

1. Simulate the condition by adding some asyncio.sleep after the await future[rid] line in InteractiveArgsDB.get.
2. Submit an experiment with interactive arguments.
3. Make two identical artiq_client supply-interactive calls within the delay in step 1.

Expected Behavior

Second supply call should throw:

ValueError: no experiment with this RID is waiting for interactive arguments

Actual (undesired) Behavior

Second supply call throws:

asyncio.exceptions.InvalidStateError: invalid state

Your System

• Operating System: NixOS
• ARTIQ version: v.8 beta (commit 13a36bf)