m32/endesive

Questions regarding changes made to fpdf.FPDF fork

Lucas-C opened this issue · 2 comments

Hi!

I'm fpdf2 maintainer, and I'm working on making this library compatible with endesive.
By the way, thank you for making your work compatible with existing libs in the Python ecosystem!

I have a couple of questions regarding some changes (in commit a036e7f) made to the FPDF class included with endesive:

  • why is the comment string %\xba\xba\xfe\xda added in the PDF document header, at fpdf/fpdf.py:1633?
  • is generating a unique /ID required for signing? cf. fpdf/fpdf.py:1633?

Closing this as I managed to implement support for signing PDFs with endesive & fpdf2 in PR py-pdf/fpdf2#466

Documentation: https://pyfpdf.github.io/fpdf2/Signing.html

m32 commented

I wanted to do it myself but I didn't know where the active version of fpfd lives (there are many). Thank you for your interest and I know where to send any changes to fpdf :)