Requests and ujson?

Question

Requests and ujson?

Closed this issue 11 years ago · 4 comments

woozyking commented 11 years ago

Hi,

Is it possible to have foursquare default to use requests and ujson libraries?

Answer 1 · 2013-09-26T21:27:29.000Z

Feel free to write pull requests for either of them (please keep them separate).

I would absolutely not require ujson, but perhaps you can send me a PR which uses it if it happens to be installed?

What do you feel the advantage of using the requests library is?

Answer 2 · 2013-09-26T21:54:36.000Z

In this particular case, requests library could be used to replace the _process_request_with_httplib2 function with almost 0 mods other than excepting different exceptions.

In terms of ujson, I think you're right. Nesting a bunch of ImportError handling could be one solution so ujson can be used when available. But after some thoughts, I'd rather just monkey patch it by doing foursquare.json = ujson to be less intrusive :)

I'll try to come up with a PR for requests usage.

Answer 3 · 2013-09-26T22:01:08.000Z

I actually wouldn't mind an ImportError solution for ujson. If it automatically patches itself over the built-in json that is.

Answer 4 · 2013-11-12T04:56:19.000Z

Done! ujson and simplejson are both supported for performance boosts.
'requests' is now the underlying HTTP library as well.