macabdul9/CASA-Dialogue-Act-Classifier

Classifier ouputs `hidden_size` values

glicerico opened this issue · 1 comments

glicerico commented

If I understand correctly, the last layer in the ContextAwareDAC is the classifier, and should output as many values as classes there are, as suggested by this line also:

CASA-Dialogue-Act-Classifier/models/ContextAwareDAC.py

Line 34 in 92358d0

nn.Linear(in_features=128, out_features=num_classes)

However, the constructor of the model seems to pass a number of classes that's equal to the hidden_size parameter in config:

CASA-Dialogue-Act-Classifier/Trainer.py

Line 38 in 92358d0

num_classes=self.config['hidden_size'],

I am guessing this is a typo, and it should say instead

num_classes=self.config['num_classes']

Also, there's no other use of config['num_classes'] anywhere else in the repository, which makes me suspect the typo even more.

macabdul9 commented

Thanks, @glicerico for pointing it out. It was a typo and I have fixed it. Closing the issue.

  • 👍1