macadmins/simpleMDMpy

Resp should be resp_json to contain all the pagination responses

lucasjhall opened this issue · 0 comments

As mentioned by @bryanheinz:
https://github.com/lucasjhall/simpleMDMpy/blob/6ed6180192fa319ef9407cd1bba8f1ce6759430e/SimpleMDMpy/SimpleMDM.py#L46

Should be:

return resp_json

While noting:

...fixing it will require returning a dictionary instead of a requests response, which will be a breaking change. i tried to load the final resp['data']` with resp_data, but got TypeError: 'Response' object does not support item assignment...