macek/google_pacman

Intro tune does not play

Closed this issue · 6 comments

I knew something was missing...

The distinct pacman startup jingle does not play :(

I also noticed that. It appears that the flash applet is not being loaded until the insert coin button is pressed, at which point it takes a moment to initialize, resulting in the missing sound. For verification notice that if you start moving right away the few few pellets are also missing their sound.

Somehow this issue does not seem to affect Google's version. Part of the cleanup of index.html must have made some sort of difference. My guess is it is somehow related to the code that causes the game to autostart on Google's homepage, but that doees not work on the local copy.

I'm planning on working on further cleanup, and perhaps documenting the Javascript, so if you don't find a fix first, I'll probably stumble across one.

I must disagree with you. Sometimes even the official Google version skips that, it's a bug in google's code, not the translation.

The way the Google code works is that if you start the game by pushing the button, the game is supposed to wait until the Flash applet is ready. However, if you don't it does not wait for that, and it also starts muted.

Macek's version lacked the line that caused it to wait for flash to load, because that was added to index.html later. My repository has a fix, and I will be issuing a pull request shortly.

Now I always get the intro music.

What I meant simply is that, on one of the localized version of google, namely the italian version, most often then not the startup music didn't fire up, while the rest of the sounds did. That's all. Glad you have it fixed though :)

Kevin has submitted revisions, I will be reviewing them this evening and merging the code. Thanks for your contributions.

Kevin, this is terrific. master and gh-pages branches have been updated :)