Highlight does not draw correctly in 8.0.1453
comradesmith opened this issue · 7 comments
Hi, thanks for this plugin, it's one of my most liked plugins.
On upgrading to Vim 8.0.1453 the yanked region no longer appeared to highlight when using vim from the terminal (Terminator and tty tested), but was working as expected in gvim. Eventually I noticed the highlight would draw if I did the following:
- yank a region
- make any movement within the highlightedyank_highlight_duration
- highlight will show until a further movement which is after the highlightedyank_highlight_duration
I have tried rolling vim-highlightedyank back to before the refactor (775326f and 44a1ea4) without success.
What has worked is downgrading to vim 8.0.550 . I wasn't sure if this issue belongs in this repo or in vim/vim, please let me know if I should post it there.
Thanks
Hi, thank you for the report. I hasten to check vim 8.0.1453, it seems it is working correctly on my computer (windows 10, cmd.exe). Could you check whether the highlight appears with pressing CTRL-L instead of any cursor movement? I think this problem related to the difference of display update trigger, it may depend on those terminal emulators.
That's a Vim issue.
Reported here: vim/vim#2612
Introduced by this patch: vim/vim@a338adc
Fixed by this patch: vim/vim@acda04f
A possible workaround is not using 44a1ea4 on Vim versions 8.0.1449 - 8.0.1476 on linux cui.
Or dummy keys via feedkeys, but that approach has a consequence of producing ugly register strings when recording macros.
@markonm Thank you!
The problem is the current Vim on Ubuntu 18.04 is 8.0.1453...
I tried to reproduce on a virtual machine but I failed. I might miss something.
I pushed a patch for this issue. Please tell me if there are any problems.
That seems to fix the issue perfectly thank you. Sorry I wasn't able to be more helpful.
That's good. Thank you both.