machine-learning-exchange/mlx

Add `id` field to notebook YAML

Closed this issue · 1 comments

ckadner commented

Currently the notebook YAMLs do not have an id or notebook_identifier field. This makes it hard to reference a notebook as a related_asset from other assets, like datasets.

Related issues:

Additional information:

The code to be changed in the MLX API:

mlx/api/server/swagger_server/controllers_impl/notebook_service_controller_impl.py

Line 398 in 3da86c7

notebook_id = existing_id or generate_id(name=name or yaml_dict["name"])

... add or yaml_dict.get("id") here:

    notebook_id = existing_id or yaml_dict.get("id") or generate_id(name=name or yaml_dict["name"])
ckadner commented

@JAulet -- I added some more info in the description.