maciejkula/spotlight

Error in BPR loss function

PeterZaidel opened this issue · 0 comments

Hello! Thank you for your great work!
In your realisation of bpr loss you use the following formula:

loss = (1.0 - torch.sigmoid(positive_predictions - negative_predictions)).

In the original publication (bpr paper) the authors propose
loss = log(sigmoid(positive - negative)) + regularisation.
Is it okay?