Django 3.0 Support
Closed this issue · 8 comments
Removing this would require dispensing with python 2.x support. Perhaps a PR with a conditional import and decorator would allow us to maintain backwards compatibility?
I'm not sure what is the most elegant way to solve this, but I did it by importing python_2_unicode_compatible from six instead of from django.utils.encoding:
@perceptiveminds That looks like the least painful solution 😅
Went ahead a made a PR from @perceptiveminds fork.
I fixed requirements.txt and the tests for Django 2+3 compatibility. Now the tests should pass. Could you try a new PR on my fork at perceptiveminds/django-registration ?
@perceptiveminds Your two latest commits have automatically been added to the PR, so no need to open another one. Glancing at the test report, it looks like the linter is complaining about import sort order.
I don't think we want to introduce a dependency on six.
My understanding is that decorator is only required with python 2.x and early Django versions.
Can you update the PR to perform a conditional import and noop the decorator when not required?
After some fixes, only the tests need the six import now.
I tried to fix the lint / tox / test errors. Only one standing:
In Django 3, the UserCreationForm contains the error message
The two password fields didn’t match
(with a non-ASCII ’ character)
To check for that message, the ’ character needs to be in tests/forms.py. But then tox / lint fails with a non-ASCII error for Python 2, even when using # coding = utf-8.
Do you know a way to fix the code to pass that test for Python 2?
(It should not matter at all, since Django 3 doesn't even run on Python 2)