Changes by PropertyLoadSaver.Load aren't cached.

[lacolaco]

Currently, goon.Get calls methods as below
.. => goon.Get => datastore.Get => goon.putMemcache => ..
or (if it's cached)
.. => goon.Get => memcache.Get => goon.putMemcache => ..

I think this flow has a problem.
PropertyLoadSaver.Load is called in only datastore.Get.
And goon.putMemcache ignores fields which tagged as datastore:"-".
Therefore the fields changed by PropertyLoadSaver.Load aren't cached.

The return of goon.Get should be same whether it's cached or not.

[lacolaco]

I have a opinion; GoonLoadSaver (provisional name) may be able to solve this issue.

GoonLoadSaver.OnGoonSave is called before datastore/mamcache.Put.

g.Put(sample) => sample.OnGoonSave() => datastore/memcache.Put => ..

GoonLoadSaver.OnGoonLoad is called after g.putMemcache.

g.Get(sample) => datastore/memcache.Get => g.putMemcache(sample) => sample.OnGoonLoad() => ..

example:

type GoonLoadSaver interface {
  OnGoonLoad(c context.Context) error
  OnGoonSave(c context.Context) error
}

func (s *Sample) OnGoonLoad(c context.Context) error {
  return nil
}

func (s *Sample) OnGoonSave(c context.Context) error {
  return nil
}

If GoonLoadSaver comes out, I can use it instead of PropertyLoadSaver.

[vvakame]

👍

[maddyblue]

Sounds great. Submit a PR and I'll review it.

[curuknagao]

i want goon loadsaver interface and found this issue.
has goon loadsaver interface already included?

[xStrom]

Not yet I'm afraid. You can track its progress in #69.