maddyblue/goread

favicons broken

fredcy opened this issue · 3 comments

Since updating to commit 4d2df60 the feed icons on the left are mostly missing/broken. With Boing Boing, for example, goread is trying to get https://boingboing.net/favicon.ico but port 443 is not available on boingboing.net. If I manually get http://boingboing.net/favicon.ico that does work.

Seems like goread should use the scheme (http/https) of the feed when getting favicons rather than using "//" prefixed URLs that inherit its own scheme.

This might be the same issue as #289. I notice that when I visit the admin page for a feed the img url value is correct and so is the displayed img image. But the feed list doesn't seem to use that. Instead it has a link directly to the feed site's favicon and always uses https scheme.

Should be fixed by #316

I just rebuilt on 60e82ac and the favicons are working again. Thanks.