madeindjs/api_on_rails

Last link on Chapter 2 goes to the wrong code

notapatch opened this issue · 3 comments

The link on 'here'

I’m not covering those in this book, since we are trying to learn how to actually implement this kind of functionality, but it is good to know though. By the way the code up to this point is here.

I believe this is the link: madeindjs/market_place_api@1248737

Confusing as it's rspec configuration when this book is covering minitest.

No this is because the project URL is https://github.com/madeindjs/market_place_api_6 . Did you found some bad link?

Yes there is a bad link. The last link in Chapter 2 in "API on Rails 6" links to the market_place_api and not to market_place_api_6. However, I can't see which commit it should link to so I cannot put a pull request in. If you click "here" at the end of Chapter 2 you can see.

Corrected by 974321c